httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: cvs commit: apache-2.0/src/lib/apr/include apr.hw apr_private.hw
Date Thu, 01 Jun 2000 02:44:19 GMT
> From: wrowe@locus.apache.org
> Date: 1 Jun 2000 01:59:20 -0000
...
> wrowe       00/05/31 18:59:20
> 
>   Modified:    src/lib/apr/include apr.hw apr_private.hw
>   Log:
>     Fix some Win32 APR feature macro declarations
>   
>   Revision  Changes    Path
>   1.15      +4 -5      apache-2.0/src/lib/apr/include/apr.hw
>   
>   Index: apr.hw
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/lib/apr/include/apr.hw,v
>   retrieving revision 1.14
>   retrieving revision 1.15
>   diff -u -r1.14 -r1.15
>   --- apr.hw	2000/05/28 02:47:09	1.14
>   +++ apr.hw	2000/06/01 01:59:19	1.15
>   @@ -137,11 +137,10 @@
>    #endif
>    
>    /*  APR Feature Macros */
>   -#define APR_HAS_THREADS  1
>   -#define APR_HAS_SENDFILE 1
>   -#define APR_HAS_MMAP     0
>   -#define APR_HAS_RANDOM   1
>   -#define APR_HAS_XLATE    0

Why not keep the zeros (APR_HAS_MMAP and APR_HAS_XLATE)?  That is more
consistent with what autoconf builds, and it will slap a Windows
programmer in the face if she accidently codes "#ifdef APR_HAS_MMAP"
instead of "#if APR_HAS_MMAP."

>   +#define APR_HAS_THREADS        1
>   +#define APR_HAS_SENDFILE       1
>   +#define APR_HAS_RANDOM         1
>   +#define APR_HAS_DSO            1
>    

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Mime
View raw message