httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Re: [PATCH] a bit of progress on the dso front
Date Tue, 30 May 2000 15:40:45 GMT
On Tue, 30 May 2000 11:32:02 -0400, Jeff Trawick wrote:

>This is tiny progress in terms of code but big progress in terms of
>whether or not the !@#$ing code will actually build out of the box.
>Linux and Solaris (and I suspect OS/390) are happy now with no
>makefile editing.
>
>Any objections to committing this as-is?

Yes, it conflicts with my patch to this same area. I think what I've done
also fixes the problem you're trying to solve here. See Message-Id
<200005290924.TAA16359@silk.apana.org.au>

Ryan's given it a grudging +1. If you think it's ok too I'll commit it.


>Index: lib/apr/misc/unix/errorcodes.c
>===================================================================
>RCS file: /cvs/apache/apache-2.0/src/lib/apr/misc/unix/errorcodes.c,v
>retrieving revision 1.18
>diff -u -r1.18 errorcodes.c
>--- errorcodes.c	2000/05/29 02:18:44	1.18
>+++ errorcodes.c	2000/05/30 15:22:15
>@@ -74,7 +74,9 @@
> 
> static char *apr_error_string(ap_status_t statcode)
> {
>+#if APR_HAS_DSO
>     char buf[256];
>+#endif
>     switch (statcode) {
>     case APR_ENOPOOL:
>         return "A new pool could not be created.";
>@@ -102,8 +104,10 @@
>         return "No thread key structure was provided and one was required.";
>     case APR_ENOSHMAVAIL:
>         return "No shared memory is currently available";
>+#if APR_HAS_DSO
>     case APR_EDSOOPEN:
>         return ap_dso_error(buf, sizeof(buf), APR_EDSOOPEN);
>+#endif
>     case APR_INCHILD:
>         return
> 	    "Your code just forked, and you are currently executing in the "
>
>
>-- 
>Jeff Trawick | trawick@ibm.net | PGP public key at web site:
>     http://www.geocities.com/SiliconValley/Park/9289/
>          Born in Roswell... married an alien...
>

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message