httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@kiwi.ICS.UCI.EDU>
Subject Re: cvs commit: apache-2.0/src/lib/apr/network_io/unix sockets.c
Date Wed, 17 May 2000 04:00:20 GMT
>  Index: sockets.c
>  ===================================================================
>  RCS file: /home/cvs/apache-2.0/src/lib/apr/network_io/unix/sockets.c,v
>  retrieving revision 1.43
>  retrieving revision 1.44
>  diff -u -r1.43 -r1.44
>  --- sockets.c	2000/05/16 20:35:39	1.43
>  +++ sockets.c	2000/05/16 21:04:20	1.44
>  @@ -113,13 +113,14 @@
>   {
>   #ifdef BEOS
>       return shutdown(thesocket->socketdes, how);
>  -#endif
>  +#else
>       if (shutdown(thesocket->socketdes, how) == 0) {
>           return APR_SUCCESS;
>       }
>       else {
>           return errno;
>       }
>  +#endif
>   }

I love this snippet -- it was part of the diff I was looking at while
composing that long e-mail rant.

Does shutdown on BEOS return errno on error, or -1 (as is defined by BSD)?
Anybody have a pointer to a web site with on-line BeOS man pages?
It claims to be POSIX, so my guess is that this is just a bug.  The code
should be simply

    return shutdown(thesocket->socketdes, how) ? errno : APR_SUCCESS;

I'll commit it.

....Roy

Mime
View raw message