httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: request_rec change inside ifdef APACHE_XLATE (?)
Date Tue, 16 May 2000 11:28:19 GMT
> On Mon, 15 May 2000, Jeff Trawick wrote:
> >...
> > diff -u -r1.45 httpd.h
> > --- httpd.h     2000/05/05 23:17:53     1.45
> > +++ httpd.h     2000/05/15 02:04:06
> > @@ -584,6 +584,15 @@
> > 
> >  #include "util_uri.h"
> > 
> > +#ifdef APACHE_XLATE
> > +#include "apr_xlate.h"
> > +
> > +struct rr_xlate {
> > +    ap_xlate_t *to_net;
> > +    ap_xlate_t *from_net;
> > +};
> 
> Namespace protection!

Will-do...  (just the structure name -- struct ap_rr_xlate {})

> There is very little reason to use bitfields in this structure. This is a
> runtime structure, allocated once per request. All the bitfields will do
> is to bungle up your code (admittedly, a little bit) later on when you
> get/set the values.
> 
> IMO, bitfields are useful only when you are trying to *really* be
> conservative about your memory usage. Even then, I might tend to use
> bitmasks.

As for the other comments...  Just in case it wasn't clear, that was
not code I was going to commit but instead was code that was shown for
background information.  It was from other projects with similar goals.

> Cheers,
> -g
> 
> -- 
> Greg Stein, http://www.lyra.org/

As always, thanks for taking the time to look at it.

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Mime
View raw message