httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Re: cvs commit: apache-2.0/src/modules/standard mod_so.c
Date Tue, 16 May 2000 02:46:06 GMT
On 15 May 2000 21:41:57 -0000, rbb@locus.apache.org wrote:

>rbb         00/05/15 14:41:57
>
>  Modified:    src/modules/standard mod_so.c
>  Log:
>  Make mod_so use ap_strerror instead of the old ap_os_dso_error.  The
>  error codes for dso's will need to be added to strerror in order for
>  this to work fully.
>  
>  Revision  Changes    Path
>  1.16      +8 -5      apache-2.0/src/modules/standard/mod_so.c
>  
>  Index: mod_so.c
>  ===================================================================
[...]
  +        ap_strerror(ap_canonical_error(status), my_error, 256);
[...]
>  +                       ap_strerror(ap_canonical_error(status), my_err, 256), NULL);

Err, why the ap_canonical_error()? You're just reducing the usefulness of
the error message by doing that. ap_strerror() is _supposed_ to take
non-canonical error codes.

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message