httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@lnd.com>
Subject RE: cvs commit: apache-2.0/src/lib/apr/time/win32 timestr.c
Date Sat, 27 May 2000 23:19:12 GMT
> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: Saturday, May 27, 2000 6:10 PM
> 
> Euh... OtherBill just backed out that rename... :-)

In accordance with both of your very explicit objections
to my very gratutious decision to sort by related groups
(AP_EXPORT_anything) - but you both stated that you objected.
And as I told you I would 1/2 hour ago.

I'm new - so I really am trying to submit by concensus.
I don't need to wait for three nays to discover that a
trivial change is objectionable :-)

HOWEVER - I won't permit us to work under two different
naming conventions!  If it must be MODULE_VAR_EXPORT for
historical reasons, I'll sleep just fine tonight.  But
I won't put up with APR_EXPORT_VAR - you'll make coders
dizzy!  It's gotta be APR_VAR_EXPORT like the rest of the 
project.

I'm done with xplat updates, what you two objected to has
been reversed, and what you didn't I've kept.

I'll write a summary of Fri eve. changes that remain, for
those who like the digested version :-)  Look for it in an
hour.

Bill

> 
> 
> On 27 May 2000 rbb@locus.apache.org wrote:
> 
> > rbb         00/05/27 16:05:11
> > 
> >   Modified:    src/lib/apr/misc/unix getopt.c
> >                src/lib/apr/time/unix timestr.c
> >                src/lib/apr/time/win32 timestr.c
> >   Log:
> >   Fixup a couple of rename's missed APR_VAR_EXPORT->APR_EXPORT_VAR
> >   
> >   Revision  Changes    Path
> >   1.15      +2 -2      apache-2.0/src/lib/apr/misc/unix/getopt.c
> >   
> >   Index: getopt.c
> >   
> ===================================================================
> >   RCS file: /home/cvs/apache-2.0/src/lib/apr/misc/unix/getopt.c,v
> >   retrieving revision 1.14
> >   retrieving revision 1.15
> >   diff -u -r1.14 -r1.15
> >   --- getopt.c	2000/05/27 22:30:11	1.14
> >   +++ getopt.c	2000/05/27 23:05:08	1.15
> >   @@ -33,12 +33,12 @@
> >    
> >    #include "misc.h"
> >    
> >   -APR_VAR_EXPORT int
> >   +APR_EXPORT_VAR int
> >        ap_opterr = 1,                      /* if error 
> message should be printed */
> >        ap_optind = 1,                      /* index into 
> parent argv vector */
> >        ap_optopt,                          /* character 
> checked for validity */
> >        ap_optreset;                        /* reset getopt */
> >   -APR_VAR_EXPORT char *ap_optarg = "";    /* argument 
> associated with option */
> >   +APR_EXPORT_VAR char *ap_optarg = "";    /* argument 
> associated with option */
> >    
> >    #define EMSG    ""
> >    
> >   
> >   
> >   
> >   1.13      +2 -2      apache-2.0/src/lib/apr/time/unix/timestr.c
> >   
> >   Index: timestr.c
> >   
> ===================================================================
> >   RCS file: /home/cvs/apache-2.0/src/lib/apr/time/unix/timestr.c,v
> >   retrieving revision 1.12
> >   retrieving revision 1.13
> >   diff -u -r1.12 -r1.13
> >   --- timestr.c	2000/05/27 22:30:12	1.12
> >   +++ timestr.c	2000/05/27 23:05:10	1.13
> >   @@ -57,11 +57,11 @@
> >    
> >    #include <string.h>
> >    
> >   -APR_VAR_EXPORT const char ap_month_snames[12][4] =
> >   +APR_EXPORT_VAR const char ap_month_snames[12][4] =
> >    {
> >        "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", 
> "Aug", "Sep", "Oct", "Nov", "Dec"
> >    };
> >   -APR_VAR_EXPORT const char ap_day_snames[7][4] =
> >   +APR_EXPORT_VAR const char ap_day_snames[7][4] =
> >    {
> >        "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
> >    };
> >   
> >   
> >   
> >   1.7       +2 -2      apache-2.0/src/lib/apr/time/win32/timestr.c
> >   
> >   Index: timestr.c
> >   
> ===================================================================
> >   RCS file: /home/cvs/apache-2.0/src/lib/apr/time/win32/timestr.c,v
> >   retrieving revision 1.6
> >   retrieving revision 1.7
> >   diff -u -r1.6 -r1.7
> >   --- timestr.c	2000/05/27 22:30:12	1.6
> >   +++ timestr.c	2000/05/27 23:05:11	1.7
> >   @@ -55,11 +55,11 @@
> >    #include "atime.h"
> >    #include "apr_portable.h"
> >    
> >   -APR_VAR_EXPORT const char ap_month_snames[12][4] =
> >   +APR_EXPORT_VAR const char ap_month_snames[12][4] =
> >    {
> >        "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", 
> "Aug", "Sep", "Oct", "Nov", "Dec"
> >    };
> >   -APR_VAR_EXPORT const char ap_day_snames[7][4] =
> >   +APR_EXPORT_VAR const char ap_day_snames[7][4] =
> >    {
> >        "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
> >    };
> >   
> >   
> >   
> > 
> 
> -- 
> Greg Stein, http://www.lyra.org/
> 

Mime
View raw message