> From: rbb@covalent.net [mailto:rbb@covalent.net]
> Sent: Friday, May 26, 2000 3:53 PM
>
> I have a bunch of issues with this patch.
>
> On 27 May 2000 wrowe@locus.apache.org wrote:
>
> > This patch corrects the issues from the AP_EXPORT and linkage
> > specification arguments to the ap_hooks.h declarations. As with
> > the APR_ and AP_ patches, API_VAR_EXPORT becomes API_EXPORT_VAR,
> > and MODULE_VAR_EXPORT becomes MODULE_EXPORT_VAR.
>
> Why? This is a name change, and a gratuitous one at that. The name
> change made sense in APR, because APR is a separate project. Here, it
> just becomes a big commit and breaks a lot of knowledge people used to
> have.
AP_EXPORT? No, it's a seperate library, ergo seperate linkage spec.
VAR_EXPORT <-> EXPORT_VAR? Either way you want to have it, I'm hearing
three negatives here, so I'm reversing out *this aspect*, within the next
1/2 hour.
>
> > I will be happy to revert the inclusion of ap_config.h from
> > httpd.h if this bothers anyone. More individual modules need
> > to be patched if we do so.
>
> There was a reason that this was changed originally. I don't remember
> what it was, but I suggest looking back at the archives.
I'll search my CD for the comments. Any idea on the timetable of that
discussion (the year would be a good start).
> > This patch also moves the following data from http_main
> to http_config:
> >
> > const char *ap_server_argv0;
> > const char *ap_server_root;
> > ap_array_header_t *ap_server_pre_read_config;
> > ap_array_header_t *ap_server_post_read_config;
> > ap_array_header_t *ap_server_config_defines;
>
> Why?
Unless someone has STRONG feelings, I am looking to isolate the code
module http_main.c to allow it to link into a seperate binary. These
args are the only thing in my way. In this, the Win32 implementation
becomes Apache.exe (of http_main.c alone) dynamically linked to all
the remaining core server code.
See the Greg comments on the remaining name changes.
|