httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@lnd.com>
Subject RE: cvs commit: apache-2.0/src/main iol_file.c
Date Sat, 27 May 2000 21:10:53 GMT
> From: rbb@covalent.net [mailto:rbb@covalent.net]
> Sent: Friday, May 26, 2000 2:56 PM
> 
> This patch is wrong, and it breaks saferead on Win32.  

correction, it was broke, and is still broken.  Thanks
for the insight, I'll walk the saferead path and possibly 
steal a trick or two from bjh's os2 patch today.

> A patch that you aren't sure about should probably not 
> be committed until it has been posted on new-httpd.  IMHO.

Since I needed to know the server will build, and I had 
kicked the tires of the server before I committed a single 
part of the patches (include the new server, which I have 
yet to layer in) - I couldn't have the interruption.

As I did, if I have q's, I ask pre or post, depending on
the state of the build.  iol_file was broke, so I committed
with the Q. iol_socket compiled, so I queried the list.



> Ryan
> 
> On Sat, 27 May 2000, William A. Rowe, Jr. wrote:
> 
> > > wrowe       00/05/27 00:06:28
> > > 
> > >   Modified:    src/main iol_file.c
> > >   Log:
> > >     A workaround since we haven't implemented the will_block 
> > > stuff in Win32.
> > >   
> > >   Revision  Changes    Path
> > >   1.18      +4 -0      apache-2.0/src/main/iol_file.c
> > >   
> > >   Index: iol_file.c
> > >   
> ===================================================================
> > >   RCS file: /home/cvs/apache-2.0/src/main/iol_file.c,v
> > >   retrieving revision 1.17
> > >   retrieving revision 1.18
> > >   diff -u -r1.17 -r1.18
> > >   --- iol_file.c	2000/05/24 22:27:16	1.17
> > >   +++ iol_file.c	2000/05/27 07:06:27	1.18
> > >   @@ -138,7 +138,11 @@
> > >        file_getopt,
> > >        NULL,
> > >        NULL,
> > >   +#ifdef WIN32
> > >   +    NULL
> > >   +#else
> > >        file_check_read
> > >   +#endif
> > >    };
> > >    
> > >    /*
> > 
> > That's it for tonight... I'm not 100% on this patch, so I 
> thought I would
> > point it out if someone else wants to take a look at a 
> better solution.
> > 
> > Win32 is building everything from the libraries through the 
> modules.  The
> > support/ exe's need more work, and I will attack those tommorow.
> > 
> > 
> > 
> 
> 
> ______________________________________________________________
> _________________
> Ryan Bloom                        	rbb@apache.org
> 406 29th St.
> San Francisco, CA 94131
> --------------------------------------------------------------
> -----------------
> 

Mime
View raw message