httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject RE: cvs commit: apache-2.0/src/modules/mpm/winnt mpm_winnt.c mpm_winnt.h registry.c service.c
Date Thu, 01 Jun 2000 01:20:57 GMT
> From: Bill Stoddard []
> Sent: Wednesday, May 31, 2000 4:34 AM
> > After I answer all the -'s issues, and get permission from 
> FirstBill,
> > I'll be happy to update the http_main.c and Apache/ApacheCore .dsp
> > files for the new service structure
> Didn't spend a lot of time reviewing the code, but it looks 
> like a definite move in the right
> direction. I had considered something similar to this (new 
> hook to handle rewriting the args, et.
> al.) but you've taken it a step further.  +1.
> In main_win32 I did a hack to extract the pid file from the 
> config on a stop/restart. You could use
> this code to move the stop logic into the pre_config hook.  
> Something is tickling my memory that
> there was a problem with that code (an implicit assumption), 
> but I can't quite remember what it
> was..

I believe the bug was an assumption that the PidFile directive was
not indented.  Or at least that was one that came to mind :-\

I'm trying to keep the code very light right now... minimizing
rather than holding on to every subroutine/feature we used to
have.  But we could definately add that back in.


View raw message