Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 38827 invoked by uid 500); 3 Apr 2000 22:25:52 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk X-No-Archive: yes Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 38814 invoked from network); 3 Apr 2000 22:25:51 -0000 Sender: jtravis Message-ID: <38E91A6D.8EA2899D@covalent.net> Date: Mon, 03 Apr 2000 17:25:49 -0500 From: Jon Travis Organization: Covalent Technologies X-Mailer: Mozilla 4.72 [en] (X11; U; Linux 2.3.99-pre3 i686) X-Accept-Language: en MIME-Version: 1.0 To: new-httpd@apache.org Subject: Re: PATCH: APR buffered I/O References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N rbb@apache.org wrote: > On Mon, 3 Apr 2000, Manoj Kasichainula wrote: > > > On Mon, Apr 03, 2000 at 05:35:15PM -0400, Ryan Bloom wrote: > > > This patch brings up an interesting question. Do we even want to support > > > buffered I/O in APR? We supported it originally because Apache needed it > > > originally. Since then, Apache has removed ALL buffered I/O support, and > > > the support in APR has fallen by the way-side. > > > > +1 on removing anything depending on stdio I/O calls. > > That's three +1's. I'll give this another day or two to let other people > pipe in, and then the stdio I/O stuff is blown out of APR. > > Ryan Heh -- I just can't win with any patches!.. ;-) Make sure you fix up the ap_fgets() routine though. After taking a quick glance, it looks like the win32 one is also broken (it can write off the end of the buffer).. -- Jon