Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Wed, 19 Apr 2000 10:50:25 -0400
Message-Id: <200004191450.KAA06196@k5.localdomain>
From: Jeff Trawick <trawickj@bellsouth.net>
To: rbb@covalent.net, new-httpd@apache.org
In-reply-to: <Pine.LNX.4.21.0004190718500.798-100000@koj.rkbloom.net>
	(rbb@covalent.net)
Subject: Re: [PATCH] 2nd draft of APR wrapper for iconv
Reply-to: trawickj@bellsouth.net
References: <Pine.LNX.4.21.0004190718500.798-100000@koj.rkbloom.net>

> > 
> > There is one minor problem I still need to address:
> > 
> > In my current implementation, listed below, we need to know whether or
> > not we HAVE_ICONV when we compile the APR client app.  This means we
> > need to include apr_config.h from apr_cp.h.  Bad!  (We have a lot of
> > symbols which aren't namespace protected.)
> > 
...
> 
> Yes, this problem has appeared before, and needs to be solved the same way
> throughout APR.  look at apr.h, and all of the APR_HAS_FOO macros.  The
> same thing should be done here.

Cool...  The simple changes to what was posted before are:

configure.in - change iconv test to

  AC_CHECK_FUNCS(iconv, [ iconv="1" ], [ iconv="0" ])

apr.h.in - add this in the "APR Feature Macros" section

  #define APR_HAS_ICONV             @iconv@

apr_cp.h - 

  change include of "aprconfig.h" to "apr.h"
  change "#if defined(HAVE_ICONV)" to "#if APR_HAS_ICONV"

Have fun,

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...