Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Message-ID: <004501bfb118$9d9c4960$c1e01b09@raleigh.ibm.com>
From: "Bill Stoddard" <stoddard@raleigh.ibm.com>
To: <new-httpd@apache.org>
References: <200004280749.RAA17819@silk.apana.org.au>
Subject: Re: Buffered APR files
Date: Fri, 28 Apr 2000 09:49:47 -0400
Organization: IBM Corp.
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit

No, doesn't work on Windows

Bill

> Is the buffered I/O stuff working on all platforms now? If so, we should
> turn it on where appropriate. EG mod_include benefits greatly from
> buffering the input file (>150% improvement in a simple test I did though
> that will vary greatly between platforms).
> 
> 
> 
> Index: mod_include.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_include.c,v
> retrieving revision 1.27
> diff -u -r1.27 mod_include.c
> --- mod_include.c 2000/04/14 15:59:09 1.27
> +++ mod_include.c 2000/04/28 07:44:24
> @@ -2389,7 +2389,7 @@
>          return HTTP_NOT_FOUND;
>      }
>  
> -    errstatus = ap_open(&f, r->filename, APR_READ, 0, r->pool);
> +    errstatus = ap_open(&f, r->filename, APR_READ|APR_BUFFERED, 0,
> r->pool);
>  
>      if (errstatus != APR_SUCCESS) {
>          ap_log_rerror(APLOG_MARK, APLOG_ERR, errstatus, r,
> 
> -- 
>  ______________________________________________________________________________
>  |  Brian Havard                 |  "He is not the messiah!                   |
>  |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
>  ------------------------------------------------------------------------------
>