From new-httpd-return-2549-apmail-new-httpd-archive=apache.org@apache.org Tue Apr 18 04:59:24 2000 Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 3730 invoked by uid 500); 18 Apr 2000 04:59:23 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk X-No-Archive: yes Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 3714 invoked from network); 18 Apr 2000 04:59:22 -0000 From: "William A. Rowe, Jr." To: Subject: RE: [PATCH] Fix segfault on Win2000 Date: Mon, 17 Apr 2000 23:58:48 -0500 Message-ID: <000001bfa8f2$d4e9b020$345985d0@corecomm.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook 8.5, Build 4.71.2173.0 Importance: Normal In-Reply-To: <200004180351.NAA05312@oznet15.ozemail.com.au> X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6600 X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N Bill, -please- commit! > From: Tim Costello [mailto:timcostello@ozemail.com.au] > Sent: Tuesday, April 18, 2000 9:51 AM > > Hi, > > This is just a minor fix for the late-binding stuff... on > Windows 2000, > GetFileAttributesExA lives at ordinal 290 - so the below > causes segfaults. Ugh - and thank you for pointing it out! That would be GetProfileSectionA in nt4... looks like they blasted all the ordinals in 2000. Does the platform sdk do something hokey to catch this all at link time? I thought all these symbols were bound by ordinal. > The change causes GetProcAddress to use the function name > instead of an > ordinal. That's why I offered them both... I've run into alot of that with the oleaut32 library (esp... functions exported early in the development cycle that wern't documented for a few versions). Hopefully Greg's obervations on whatever hashing they do with the symbol names pans out! > Tim > > ===== BEGIN PATCH ===== > > --- > /srclib/repos/apache/2.0/src/src/lib/apr/include/apr_co > nfig.hw Mon Apr 17 09:12:00 2000 > +++ src/lib/apr/include/apr_config.hw Tue Apr 18 13:22:42 2000 > @@ -204,7 +204,7 @@ > * In the case of non-text functions, simply #define the > original name > */ > > -DECLARE_LATE_DLL_FUNC(DLL_WINBASEAPI, BOOL, WINAPI, > GetFileAttributesExA, 234, ( > +DECLARE_LATE_DLL_FUNC(DLL_WINBASEAPI, BOOL, WINAPI, > GetFileAttributesExA, 0, ( > IN LPCSTR lpFileName, > IN GET_FILEEX_INFO_LEVELS fInfoLevelId, > OUT LPVOID lpFileInformation), > > ===== END PATCH ===== > This message was sent through MyMail http://www.mymail.com.au > >