httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: Buffered APR files
Date Fri, 28 Apr 2000 11:34:49 GMT
On Fri, 28 Apr 2000, Brian Havard wrote:

> Is the buffered I/O stuff working on all platforms now? If so, we should
> turn it on where appropriate. EG mod_include benefits greatly from
> buffering the input file (>150% improvement in a simple test I did though
> that will vary greatly between platforms).

Please wait until after the alpha, and turn it on.  If it doesn't work
someplace, we'[ll find out, and we can fix it before the next alpha.

Ryan

> 
> 
> 
> Index: mod_include.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_include.c,v
> retrieving revision 1.27
> diff -u -r1.27 mod_include.c
> --- mod_include.c	2000/04/14 15:59:09	1.27
> +++ mod_include.c	2000/04/28 07:44:24
> @@ -2389,7 +2389,7 @@
>          return HTTP_NOT_FOUND;
>      }
>  
> -    errstatus = ap_open(&f, r->filename, APR_READ, 0, r->pool);
> +    errstatus = ap_open(&f, r->filename, APR_READ|APR_BUFFERED, 0,
> r->pool);
>  
>      if (errstatus != APR_SUCCESS) {
>          ap_log_rerror(APLOG_MARK, APLOG_ERR, errstatus, r,
> 
> -- 
>  ______________________________________________________________________________
>  |  Brian Havard                 |  "He is not the messiah!                   |
>  |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
>  ------------------------------------------------------------------------------
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message