httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [APR] writev Problem (HAVE_WRITEV / NO_WRITEV / ap_writev)
Date Mon, 10 Apr 2000 12:03:16 GMT
On Mon, 10 Apr 2000, Martin Kraemer wrote:

> I see a problem in the current apache_2.0 code regarding the portability
> to machines that lack the writev system call.
> 
> The current situation is like this:
> * configure tests whether writev is available and sets HAVE_WRITEV
>   accordingly
> * file_io/unix/readwrite.c checks HAVE_WRITEV and defines the function
>   ap_writev() based on writev() if HAVE_WRITEV is set
> * main/iol_file.c calls ap_writev() from file_ap_writev()
> 
> IMHO the second step should *ALWAYS* define ap_writev(), possibly as an
> emulation wrapper based on write(), *OR*
> all functions using ap_writev() should be able to emulate it (based on
> ap_write()) if HAVE_WRITEV is not set. Of course, the latter is a stupid
> idea.
> 
> What was the design idea behind it?

Definately a bug.  The original idea was to implement option 1, but nobody
ever did it.  Feel free to do it yourself.  :-)

Ryan


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message