httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <do...@covalent.net>
Subject Re: minor pollution
Date Fri, 28 Apr 2000 18:25:07 GMT
On Fri, 28 Apr 2000, Bill Stoddard wrote:

> > * function find_child_by_pid modules/mpm/mpmt_pthread/scoreboard.c:205
> > this is API_EXPORT-ed, should have an ap_ prefix
> > 
> > * variable g_bDebugHooks 
> > * variable g_pHookPool 
> > * variable g_szCurrentHookName 
> > 
> 
> I kinda like the idea of globals being named to identify them as such. 

we need to be consistent, currently all the other globals are named with
the same convention as functions.  i don't mind change all the globals to
use the same convention, which would be:

ap_g_variable
or
AP_variable
or ?

here's the current list of globals i can see:
08096430 B ap_listeners
0809640c B ap_my_generation
08096444 B ap_optopt
08096440 B ap_optreset
08096428 B ap_server_argv0
0809641c B ap_server_config_defines
08096418 B ap_server_post_read_config
08096424 B ap_server_pre_read_config
08096420 B ap_server_root
08096410 B g_bDebugHooks
0809642c B g_pHookPool
08096414 B g_szCurrentHookName
08096434 B unixd_config



Mime
View raw message