httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <do...@covalent.net>
Subject Re: cvs commit: apache-2.0/src/os/win32/installer/installdll/test test.c
Date Fri, 28 Apr 2000 18:20:35 GMT
> Are you sure APR's MM should be converted, too? AFAIK MM inside APR
> doesn't include apr_general.h. MM is a stand-alone library which is just
> staying inside the APR tree. But it doesn't use APR, so it cannot (and
> IMHO also should not) use APR's APR_FALSE/APR_TRUE values.

right, i meant to leave the mm stuff alone, i will back those out.
 
> BTW, I'm also personally not convinced that own APR_{TRUE,FALSE} values
> are very useful. FALSE is _ALWAYS_ 0 and TRUE is just not FALSE. So it
> is usually never a problem to use
> 
> #ifndef FALSE
> #define FALSE 0
> #endif
> #ifndef TRUE
> #define TRUE !FALSE
> #endif

yeah, this was my first suggestion, look like i might backup to that,
since APR_{TRUE,FALSE} is breaking things.


Mime
View raw message