httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/mmap/unix mmap.c
Date Sun, 09 Apr 2000 08:26:37 GMT
Ryan -- you've been going nuts lately, identifying a whole ton of issues.
I'm losing track :-). Any chance that you could also put your ideas into
the STATUS file? Other people may want to jump in one some of the things
that you've identified.

Cheers,
-g

On Fri, 7 Apr 2000 rbb@apache.org wrote:
> > >The general feeling was that Apache is doing the buffering with the BUFF
> > >code, and we don't need to do buffering twice in Apache (once in Apache
> > >and once in APR).
> > 
> > Yes, BUFF is used for files being served but ap_fgets is used for things
> > like reading config files & without buffering you end up with a read()
> > syscall or the platform equivalent for every individual byte. This may or
> > may not have a noticable impact on performance in Apache (mod_auth may),
> > you'd have to do some benchmarking to find out.
> 
> I know this is an issue.  I have plans to get rid of this and use ap_read
> and ap_write instead of ap_fgets and ap_fgetch.  This may take a few days
> to finish though.
> 
> I just can't see a good reason to support buffering in multiple places in
> Apache/APR.  If we have everything use BUFF's, then we can remove a lot of
> the ugly read/write code in APR, and we have a common usable way to
> read/write files/networks/foo in the server.
> 
> Ryan
> 
> 
> _______________________________________________________________________________
> Ryan Bloom                        	rbb@apache.org
> 406 29th St.
> San Francisco, CA 94131
> -------------------------------------------------------------------------------
> 

-- 
Greg Stein, http://www.lyra.org/


Mime
View raw message