httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: PATCH: APR buffered I/O
Date Mon, 03 Apr 2000 21:35:15 GMT


This patch brings up an interesting question.  Do we even want to support
buffered I/O in APR?  We supported it originally because Apache needed it
originally.  Since then, Apache has removed ALL buffered I/O support, and
the support in APR has fallen by the way-side.

Just asking.

Ryan

On Mon, 3 Apr 2000, Greg Stein wrote:

> Watch out for sign extension in ap_ungetc() !!
> 
> It is quite possible that somebody passes in \xFF and the assignment to
> ->ungetchar will sign-extend to -1.
> 
> The assignment should look something like:
> 
>   thefile->ungetchar = (unsigned char)ch;
> 
> Cheers,
> -g
> 
> 
> On Mon, 3 Apr 2000, Jon Travis wrote:
> 
> > Attached are some patches to get ungetc() working in APR for
> > non-buffered
> > file descriptors.  In addition, I believe I fixed a bug with the
> > ap_fgets() under
> > Unix (it looks like Win32 has it correct).  I have tested out all these
> > changes,
> > but please poke a careful eye into it anyway.. ;-)
> > 
> > Also, I noticed that ap_seek() has arguments in reverse order from what
> > UNIX
> > says that they should be.  Perhaps we should change this for consistancy
> > sake?
> > 
> > -- Jon
> > 
> > 
> > 
> 
> -- 
> Greg Stein, http://www.lyra.org/
> 
> 
> 
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message