httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject ap_file_t typedef (was: cvs commit: apache-2.0/src/lib/apr/include apr_file_io.h)
Date Mon, 03 Apr 2000 18:18:40 GMT
On 3 Apr 2000 rbb@locus.apache.org wrote:
> rbb         00/04/03 10:14:12
> 
>   Modified:    src/lib/apr APRDesign
>                src/lib/apr/file_io/beos readwrite.c
>                src/lib/apr/file_io/os2 fileacc.c filedup.c fileio.h
>                         filestat.c open.c pipe.c readwrite.c seek.c
>                src/lib/apr/file_io/unix fileacc.c filedup.c fileio.h
>                         filestat.c open.c pipe.c readwrite.c seek.c
>                src/lib/apr/file_io/win32 fileacc.c filedup.c fileio.h
>                         filestat.c open.c pipe.c readwrite.c seek.c
>                src/lib/apr/include apr_file_io.h
>   Log:
>   Change struct file_t to struct ap_file_t.  This clarifies things a bit that
>   APR defines both the struct and typedef's it.  This is also the way things
>   should have been coded originally, so this just fixes it.  Expect more of
>   these patches today.

I do not understand why we use "struct ap_file_t" everywhere instead of
simply "ap_file_t" (the typedef).

A lot of code would be cleaner with just the typedef, IMO.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/


Mime
View raw message