httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tony Finch <f...@apache.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/include apr_time.h
Date Wed, 12 Apr 2000 18:38:42 GMT
dgaudet@locus.apache.org wrote:
>  --- apr_time.h	2000/03/31 08:35:56	1.14
>  +++ apr_time.h	2000/04/11 16:21:21	1.15
>  @@ -71,6 +71,12 @@
>   #ifdef WIN32
>   #define AP_USEC_PER_SEC ((LONGLONG) 1000000)
>   #else
>  +/* XXX: this is wrong -- the LL is only required if int64 is implemented as
>  + * a long long, it could be just a long on some platforms.  the C99
>  + * correct way of doing this is to use INT64_C(1000000) which comes
>  + * from stdint.h.  we'd probably be doing a Good Thing to check for
>  + * INT64_C in autoconf... or otherwise define an AP_INT64_C(). -dean
>  + */
>   #define AP_USEC_PER_SEC (1000000LL)
>   #endif

Why not just drop the suffix completely and let integer promotion do
the trick?

Tony.
-- 
f.a.n.finch    fanf@demon.net    dot@dotat.at
385 pulverized funnybone jelly

Mime
View raw message