httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apache-2.0/src/os/win32/installer/installdll/test
Date Sat, 29 Apr 2000 10:21:05 GMT
Jim Jagielski wrote:
> 
> Ben Laurie wrote:
> >
> > For God's sake. Get real.
> 
> Nah. Too fun not to :)
> 
> >
> > #define int double
> >
> > we get weirdness. Are we going to invent ap_int and ap_double to "fix"
> > this problem?
> >
> 
> I don't think TRUE or FALSE falls into the same sort of "protected
> cookie" that int et.al. does :) Also, it's not so much FALSE which
> is the one to be "careful" about, it's TRUE.

Hmm. Well, K&R define the value of "true" to be 1, so, although they
don't protect the name, they certainly do protect the value.

> What we're saying is that we want FALSE to be 0, but to avoid compiler
> (OK, preprocessor) warnings we only force it if not already set. My
> point is why not just force it and say to hell with the world :) :)

Because you get warnings. I'd be OK with:

#ifdef TRUE
# undef TRUE
#endif
#define TRUE 1

> If doing that scares people, then we "protect" the real ones
> with good ol' APR_ ;)

That's just too stupid.

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

Mime
View raw message