httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apache-2.0/src/os/win32/installer/installdll/test
Date Fri, 28 Apr 2000 20:06:26 GMT
Jim Jagielski wrote:
> 
> Doug MacEachern wrote:
> >
> > right, i meant to leave the mm stuff alone, i will back those out.
> >
> > > BTW, I'm also personally not convinced that own APR_{TRUE,FALSE} values
> > > are very useful. FALSE is _ALWAYS_ 0 and TRUE is just not FALSE. So it
> > > is usually never a problem to use
> > >
> > > #ifndef FALSE
> > > #define FALSE 0
> > > #endif
> > > #ifndef TRUE
> > > #define TRUE !FALSE
> > > #endif
> >
> 
> Well, all it takes is one weird header file to incorrectly
> define FALSE and/or TRUE and things will break strangely.
> If we need FALSE to be false (0) then that's that. We shouldn't
> allow people to redefine it ;)

For God's sake. Get real.

#define int double

we get weirdness. Are we going to invent ap_int and ap_double to "fix"
this problem?

#define n m

I dread to think what this would do. I know, let's make all local
variable have ap_ in front. Oops, now what about:

#define ap_n ap_m

Sheesh.

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

Mime
View raw message