httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rodent of Unusual Size <Ken.C...@Golux.Com>
Subject Re: [PATCH] 2nd draft of APR wrapper for iconv
Date Wed, 19 Apr 2000 17:21:31 GMT
Rodent of Unusual Size wrote:
> > 1) in honor of Ryan's new ap_cp_XXX function names, I changed:
> >
> >    a) the name of the handle type from ap_iconv_t to ap_cp_t
> >    b) the name of the header file from apr_iconv.h to apr_cp.h
> >    c) the name of the Unix source file from
> >       lib/apr/iconv/unix/apr_iconv.c to lib/apr/cp/unix/cp.c

To make myself clearer, my objection is to the "ap_cp*" syntax.
If iconv isn't a universal thing (I thought it was -- my
mistake, unless we're going to end up bundling it or adding
it to APR as part of the portability), then "ap_iconv*" isn't
appropriate either.

"ap_cp_*" is a meaningless noise; if you don't know what's
going on you have no chance of figuring it out from the name.
Plug that into a search engine and you'll get something
misleading.  "ap_codepage*" is long and clunky, but better
than ap_cp.  Maybe "ap_xlate"?

But -1 on the ap_cp name scheme.
#ken    P-)}

Ken Coar                    <http://Golux.Com/coar/>
Apache Software Foundation  <>
"Apache Server for Dummies" <http://Apache-Server.Com/>
"Apache Server Unleashed"   <http://ApacheUnleashed.Com/>

View raw message