httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jon Travis <jtra...@covalent.net>
Subject Re: PATCH: APR buffered I/O
Date Mon, 03 Apr 2000 22:25:49 GMT
rbb@apache.org wrote:

> On Mon, 3 Apr 2000, Manoj Kasichainula wrote:
>
> > On Mon, Apr 03, 2000 at 05:35:15PM -0400, Ryan Bloom wrote:
> > > This patch brings up an interesting question.  Do we even want to support
> > > buffered I/O in APR?  We supported it originally because Apache needed it
> > > originally.  Since then, Apache has removed ALL buffered I/O support, and
> > > the support in APR has fallen by the way-side.
> >
> > +1 on removing anything depending on stdio I/O calls.
>
> That's three +1's.  I'll give this another day or two to let other people
> pipe in, and then the stdio I/O stuff is blown out of APR.
>
> Ryan

Heh -- I just can't win with any patches!.. ;-)  Make sure you fix up the
ap_fgets() routine though.  After taking a quick glance, it looks like the
win32 one is also broken (it can write off the end of the buffer)..

-- Jon


Mime
View raw message