httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: [PATCH 2.0] difftime for apr (was Short list of stuff to consider pre alpha)
Date Sat, 29 Apr 2000 23:28:14 GMT
> > From: William A. Rowe, Jr. [mailto:wrowe@lnd.com]
> > Sent: Thursday, April 27, 2000 1:00 PM
> > 
> > Suggestions (I won't have extra time on this till next week, 
> > but really
> > want to see some of this in the new package, all builds, there is one
> > odd error left in the win32 build, relating to the poll changes, that
> > I don't have time to look at) -
> 
> I'm following up, since there is one set within these suggestions
> that I'm loath to implement until some others take a look;
> 
> > 6) add ap_difftime... but this really points out the weakness of this type!
> >    I really, really believe that ap_interval_time_t must be 64 bits,
> >    but that's a patch in and of itself, with some cpu ramifications.
> > 
> > 8) fix up mod_auth_digest.c - but this requires some VERY CAREFUL review.
> >    Not that it was any good with times before... but let's assure it is right.
> 
> Using the current declarations, ap_interval_time_t is restricted to just a little
> over 35 seconds... that's rather absurd!  I don't like the patch for that reason,
> but I'm not about to go flipping ap_interval_time_t to 64 bits without some more
> feedback from other platforms.

Hmmm...  I get more than 35 seconds worth of microseconds.  Feel free
to correct my math.

Let's calculate...  A 32-bit signed integer can store up to 
2,147,483,647 microseconds.  Divide that by the number of microseconds
in a second (1,000,000) and you get 2,147 seconds worth of
microseconds in an ap_interval_time_t.  That is 35 minutes and 46-odd
seconds. 

That is good enough for me, and I don't need to make those 32-bit
processors work very hard to pass it around and perform arithmetic
operations with it.

Personally, I don't think ap_difftime() is so necessary but it won't
hurt my feelings if it goes in.

Have fun,

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Mime
View raw message