httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Include paths & shared APR modules
Date Thu, 20 Apr 2000 15:04:26 GMT
In the case of non-unix platforms using the default unix implementation
we're seeing a fair bit if this sort of thing:

#ifndef BEOS
#include "../../threadproc/unix/threadproc.h"
#else
#include "../../threadproc/beos/threadproc.h"
#endif


Now, to make this work on OS/2 I need to add yet another #elif. IMHO I
think it would be better to do something like

Index: lib/apr/misc/unix/Makefile.in
===================================================================
RCS file: /home/cvs/apache-2.0/src/lib/apr/misc/unix/Makefile.in,v
retrieving revision 1.13
diff -u -r1.13 Makefile.in
--- lib/apr/misc/unix/Makefile.in	2000/04/19 22:39:34	1.13
+++ lib/apr/misc/unix/Makefile.in	2000/04/20 13:48:12
@@ -10,8 +10,10 @@
 LIBS=@LIBS@
 LDFLAGS=@LDFLAGS@ $(LIBS)
 INCDIR1=../../include
-INCDIR2=../../file_io/unix
-INCLUDES=-I$(INCDIR1) -I$(INCDIR2) -I.
+INCDIR2=../../file_io/@OSDIR@
+INCDIR3=../../locks/@OSDIR@
+INCDIR4=../../threadproc/@OSDIR@
+INCLUDES=-I$(INCDIR1) -I$(INCDIR2) -I$(INCDIR3) -I$(INCDIR4) -I.
 
 #LIB=libmisc.a
 

That way in the .c files you can just say
#include "threadproc.h"

Anyone agree with me?

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message