httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <>
Subject Re: cvs commit: apache-2.0/src/lib/apr/file_io/win32 filestat.c
Date Wed, 12 Apr 2000 14:44:45 GMT
In code like this:

  +        if (hFind == INVALID_HANDLE_VALUE) {
  +            return GetLastError();

Aren't we supposed to be adding a magic constant to GetLastError() in
order to build an ap_status_t (and/or inventing a macro to do that
under the covers)? 

This is just a gentle reminder that new code should do that and old
code should be repaired as time is available.

Jeff Trawick | | PGP public key at web site:
          Born in Roswell... married an alien...

View raw message