httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Reid" <>
Subject Re: cvs commit: apache-2.0/src/lib/apr/test testoc.c
Date Wed, 05 Apr 2000 09:22:02 GMT

Yes, most of the code is the same, and yes it will disappear at some point
in the coming days.  Why is the code a simple copy?  Well, it was 11pm and I
simply dragged and dropped to get the stuff working.  Once I've got time
I'll review and see if I can use the unix code, just as I've done in the
past!  Some of the code in the file gave me pause as BeOS can be a little
strange about some things, which is why I did it this way.

I don't want any more code duplication than is neccesary either, which is
why I added the ability for platforms to have their own directories only
when needed.  A lot of the BeOS code is in fact following this philosophy
and so far it works very well.  Look at the AIX directory in the dso.
everywhere else AIX will use the same basic code as unix, but for that one
part of APR it'll use it's own code as it's "different".  Take a look at the
time directory - no beos directory!  Nope, it just uses the unix files.
Whilst Ryan was working on APR in the early days we had this discussion and
found these solutions.

Am I concerned?  No!

----- Original Message -----
From: "Bill Stoddard" <>
To: <>
Sent: Wednesday, April 05, 2000 3:18 PM
Subject: Re: cvs commit: apache-2.0/src/lib/apr/test testoc.c

> Is anyone else concerned about the amount of code duplicated in each os
> branch in APR?  Much of this code (maybe all of it, I've not looked
> is exactly the same as the code in the Unix branch. I'm not picking on you
> David, there is duplicated code all over APR and I've been concerned about
> it for awhile now. I see much of this code diverging over time with fixes
> put in one place but not the other and we end up shooting the same bugs
> and over for each platform. I would rather see a -few- #ifdefs rather than
> code duplicated because of minor platform differences.
> >   1.1                  apache-2.0/src/lib/apr/misc/beos/otherchild.c
> >
> >

View raw message