httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <stodd...@raleigh.ibm.com>
Subject Re: cvs commit: apache-2.0/src/lib/apr/include apr.hw apr_config.hw
Date Wed, 05 Apr 2000 13:48:11 GMT

> On 4 Apr 2000 stoddard@locus.apache.org wrote:
>
> > stoddard    00/04/04 14:31:06
> >
> >   Modified:    src/lib/apr/file_io/win32 open.c
> >                src/lib/apr/include apr.hw apr_config.hw
> >   Log:
> >   Windows specific ap_oslevel modifications.
> >   Move ap_oslevel_e out of ap_config.hw (private to APR) and into apr.hw
(public)
> >   and allow finer grained OS level checking.
>
> ap_oslevel is an internal APR function.  We have had this discussion
> before, and we have always decided to leave it as an internal function.
> The APR app should not know what level of the system it is on.  I am -1 on
> making this a public function until we have seen a program that actually
> requires this knowledge.
>

My bad. I though we had decided to make it public.  I can think of some
contrived cases where we might want it public, but I have no strong feeling
about it one way or the other. I'll make it private again and add a function
prototype while I'm at it.

Bill


Mime
View raw message