httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@lnd.com>
Subject RE: [PATCH 2.0] difftime for apr (was Short list of stuff to consider pre alpha)
Date Sat, 29 Apr 2000 17:30:30 GMT
> From: William A. Rowe, Jr. [mailto:wrowe@lnd.com]
> Sent: Thursday, April 27, 2000 1:00 PM
> 
> Suggestions (I won't have extra time on this till next week, 
> but really
> want to see some of this in the new package, all builds, there is one
> odd error left in the win32 build, relating to the poll changes, that
> I don't have time to look at) -

I'm following up, since there is one set within these suggestions
that I'm loath to implement until some others take a look;

> 6) add ap_difftime... but this really points out the weakness of this type!
>    I really, really believe that ap_interval_time_t must be 64 bits,
>    but that's a patch in and of itself, with some cpu ramifications.
> 
> 8) fix up mod_auth_digest.c - but this requires some VERY CAREFUL review.
>    Not that it was any good with times before... but let's assure it is right.

Using the current declarations, ap_interval_time_t is restricted to just a little
over 35 seconds... that's rather absurd!  I don't like the patch for that reason,
but I'm not about to go flipping ap_interval_time_t to 64 bits without some more
feedback from other platforms.



Mime
View raw message