Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 941 invoked by uid 500); 2 Mar 2000 22:14:10 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk X-No-Archive: yes Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 919 invoked from network); 2 Mar 2000 22:14:09 -0000 From: pg@sweng.stortek.com Message-id: <200003022213.PAA02184@sanitas> Subject: Re: cvs commit: apache-1.3/src/main buff.c To: new-httpd@apache.org Date: Thu, 2 Mar 2000 15:13:34 -0700 (MST) In-Reply-To: from "Greg Stein" at Mar 02, 2000 02:00:48 PM X-Mailer: ELM [version 2.5 PL0] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N In a recent note, Greg Stein said: > Date: Thu, 2 Mar 2000 14:00:48 -0800 (PST) > > Why should the ascii_CRLF macro even exist? The protocol is explicit that > those characters must be \015\012. That constant should be used rather > than a macro. > > If you *do* want to retain a macro (for symbolic purposes), then please > force it to always be "\015\012" rather than using an #ifdef and possibly > depending on CRLF. > > > +#ifdef CHARSET_EBCDIC > > +#define ascii_CRLF "\015\012" /* A CRLF which won't pass the conversion machinery */ > > +#else > > +#define ascii_CRLF CRLF > > +#endif > > I agree. Both path through this are equivalent to the unconditional: > > +#define ascii_CRLF "\015\012" /* A CRLF which won't pass the conversion machinery */ -- gil -- StorageTek INFORMATION made POWERFUL