httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: cvs commit: apache-2.0/src/lib/apr/locks/unix crossproc.c
Date Tue, 21 Mar 2000 14:44:21 GMT

The commit I made later last night takes care of this problem.  If we did
without cleaning up after the last commit, then we are really SOL.

Ryan


On Tue, 21 Mar 2000, Jim Jagielski wrote:

> We still need to worry about crashes that are severe enough to have
> Apache die before it can even do this... Maybe at start-up
> looking for sems owned by Apache (like when 1.3 sees an unclean
> crash) and deleting these?? Then again, maybe not...
> 
> rbb@locus.apache.org wrote:
> > 
> > rbb         00/03/20 17:32:59
> > 
> >   Modified:    src/lib/apr/locks/unix crossproc.c
> >   Log:
> >   Fix the cleanup of SYSV semaphores.  This way we don't leave sems lying
> >   around forever.
> >   Submitted by:	Jeff Trawick
> >   Reviewed by:	Ryan Bloom
> >   
> >   Revision  Changes    Path
> >   1.17      +1 -1      apache-2.0/src/lib/apr/locks/unix/crossproc.c
> >   
> >   Index: crossproc.c
> >   ===================================================================
> >   RCS file: /home/cvs/apache-2.0/src/lib/apr/locks/unix/crossproc.c,v
> >   retrieving revision 1.16
> >   retrieving revision 1.17
> >   diff -u -r1.16 -r1.17
> >   --- crossproc.c	2000/03/16 22:59:54	1.16
> >   +++ crossproc.c	2000/03/21 01:32:59	1.17
> >   @@ -74,7 +74,7 @@
> >        struct lock_t *lock=lock_;
> >        union semun ick;
> >        
> >   -    if (lock->curr_locked == 1) {
> >   +    if (lock->curr_interproc != -1) {
> >            ick.val = 0;
> >            semctl(lock->interproc, 0, IPC_RMID, ick);
> >        }
> >   
> >   
> >   
> > 
> 
> 
> -- 
> ===========================================================================
>    Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
>                 "Are you suggesting coconuts migrate??"
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message