httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject RE: cvs commit: apache-1.3/src/include ap_mmn.h
Date Tue, 21 Mar 2000 06:05:27 GMT
We decided some time last year (at least) that appending a field will not
require a MAJOR bump. While it is strictly true that sizeof(request_rec)
has changed, we made a policy choice that people won't be doing that
and/or it is unsupported. In short: structure additions will only cause a
minor bump.

Looking at the comments in ap_mmn.h, you'll see that we've added fields
several times without a major bump.

Cheers,
-g

On Mon, 20 Mar 2000, Randy Terbush wrote:
> Sorry to be a pest about this.
> 
> Structure changes should be a MAJOR number change. While I agree that you
> can often get away with adding to the end of a structure, this is not the
> case on all architectures and all compilers.
> 
> > -----Original Message-----
> > From: stoddard@locus.apache.org [mailto:stoddard@locus.apache.org]
> > Sent: Monday, March 20, 2000 7:51 PM
> > To: apache-1.3-cvs@apache.org
> > Subject: cvs commit: apache-1.3/src/include ap_mmn.h
> >
> >
> > stoddard    00/03/20 19:50:43
> >
> >   Modified:    src/include ap_mmn.h
> >   Log:
> >   Update minor module magic number to reflect the new field
> > (case_preserved_filename)
> >
> >   Revision  Changes    Path
> >   1.45      +1 -1      apache-1.3/src/include/ap_mmn.h
> >
> >   Index: ap_mmn.h
> >   ===================================================================
> >   RCS file: /home/cvs/apache-1.3/src/include/ap_mmn.h,v
> >   retrieving revision 1.44
> >   retrieving revision 1.45
> >   diff -u -r1.44 -r1.45
> >   --- ap_mmn.h	2000/02/20 01:14:46	1.44
> >   +++ ap_mmn.h	2000/03/21 03:50:43	1.45
> >   @@ -234,7 +234,7 @@
> >    #ifndef MODULE_MAGIC_NUMBER_MAJOR
> >    #define MODULE_MAGIC_NUMBER_MAJOR 19990320
> >    #endif
> >   -#define MODULE_MAGIC_NUMBER_MINOR 7                     /* 0...n */
> >   +#define MODULE_MAGIC_NUMBER_MINOR 8                     /* 0...n */
> >    #define MODULE_MAGIC_NUMBER MODULE_MAGIC_NUMBER_MAJOR	/*
> > backward compat */
> >
> >    /* Useful for testing for features. */
> >
> >
> >
> >
> 

-- 
Greg Stein, http://www.lyra.org/


Mime
View raw message