httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: [PATCH] win32 ap_puts() shouldn't add '\n'
Date Sun, 19 Mar 2000 15:06:45 GMT

+1.

Ryan

On Sat, 18 Mar 2000, Jeff Trawick wrote:

> (not wishing to rekindle any old debates here; just want
> apache -h to look nice on win32)
> 
> RCS file:
> /cvs/apache/apache-2.0/src/lib/apr/file_io/win32/readwrite.c,v
> retrieving revision 1.14
> diff -u -r1.14 readwrite.c
> --- readwrite.c 2000/03/10 00:06:06     1.14
> +++ readwrite.c 2000/03/18 20:10:24
> @@ -199,12 +199,9 @@
>      int len;
> 
>      len = strlen(str);
> -    str[len] = '\n';
> -    if (!WriteFile(thefile->filehand, str, len+1, &bwrote, NULL)) {
> -        str[len] = '\0';
> +    if (!WriteFile(thefile->filehand, str, len, &bwrote, NULL)) {
>          return GetLastError();
>      }
> -    str[len] = '\0';
> 
>      return APR_SUCCESS;
>  }
> 
> 
> -- 
> Jeff Trawick | trawick@ibm.net | PGP public key at web site:
>      http://www.geocities.com/SiliconValley/Park/9289/
>           Born in Roswell... married an alien...
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message