httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/locks/unix crossproc.c
Date Thu, 16 Mar 2000 20:55:42 GMT
On 16 Mar 2000 rbb@locus.apache.org wrote:
>   diff -u -r1.13 -r1.14
>   --- crossproc.c	2000/03/10 00:06:17	1.13
>   +++ crossproc.c	2000/03/16 20:49:51	1.14
>   @@ -376,6 +376,7 @@
>    
>        new = (struct lock_t *)ap_palloc(cont, sizeof(struct lock_t));
>    
>   +    ap_cpystrn(new->fname, fname, strlen(fname));
>        new->interproc = open(new->fname, O_CREAT | O_WRONLY | O_EXCL, 0600);
>        if (new->interproc == -1) {
>            destroy_inter_lock(new);

Why use ap_cpystrn() and pass strlen(fname) ? Shouldn't this simply be:

   strcpy(new->fname, fname)

??

-- 
Greg Stein, http://www.lyra.org/


Mime
View raw message