httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ask Bjoern Hansen <...@valueclick.com>
Subject Re: cvs commit: apache-devsite robots.txt
Date Mon, 13 Mar 2000 09:22:54 GMT
On 12 Mar 2000 dgaudet@locus.apache.org wrote:

> dgaudet     00/03/12 10:45:10
> 
>   Added:       .        robots.txt
>   Log:
>   found on server, not in CVS
>   
>   Revision  Changes    Path
>   1.1                  apache-devsite/robots.txt
>   
>   	<<Binary file>>

nitpicking here, but netscape acts up on empty files. It might be good to
put a space or something in it.

Also, log_accum.pl's binary logic would be improved by

*** /home/cvs/CVSROOT/log_accum.pl      Tue Mar  7 11:39:12 2000
--- log_accum.pl        Mon Mar 13 01:19:41 2000
***************
*** 213,219 ****
        # Perl's 'is this binary' algorithm; it's pretty good.  But not
        # perfect.
        #
!       if (($file =~ /\.(?:pdf|gif|jpg|mpg)$/i) || (-B $file)) {
            $diff .= "\t<<Binary file>>\n\n";
        }
        else {
--- 213,219 ----
        # Perl's 'is this binary' algorithm; it's pretty good.  But not
        # perfect.
        #
!       if (($file =~ /\.(?:pdf|gif|jpg|mpg)$/i) || (!-T $file)) {
            $diff .= "\t<<Binary file>>\n\n";
        }
        else {

since both -B and -T reports true on empty files. (which will never
put anything in that will screw up any mail programs).


 - ask

-- 
ask bjoern hansen - <http://www.netcetera.dk/~ask/>
more than 70M impressions per day, <http://valueclick.com>


Mime
View raw message