httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From p.@sweng.stortek.com
Subject Re: cvs commit: apache-1.3/src/main buff.c
Date Thu, 02 Mar 2000 22:13:34 GMT
In a recent note, Greg Stein said:

> Date: Thu, 2 Mar 2000 14:00:48 -0800 (PST)
> 
> Why should the ascii_CRLF macro even exist? The protocol is explicit that
> those characters must be \015\012. That constant should be used rather
> than a macro.
> 
> If you *do* want to retain a macro (for symbolic purposes), then please
> force it to always be "\015\012" rather than using an #ifdef and possibly
> depending on CRLF.
> 
> >   +#ifdef CHARSET_EBCDIC
> >   +#define ascii_CRLF "\015\012" /* A CRLF which won't pass the conversion machinery
*/
> >   +#else
> >   +#define ascii_CRLF CRLF
> >   +#endif
> >    
I agree.  Both path through this are equivalent to the unconditional:

> >   +#define ascii_CRLF "\015\012" /* A CRLF which won't pass the conversion machinery
*/

-- gil
-- 
StorageTek
INFORMATION made POWERFUL

Mime
View raw message