httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <stodd...@raleigh.ibm.com>
Subject Re: [PATCH] Proxy Garbage Collection Bug/Win32 PR#4139
Date Mon, 06 Mar 2000 14:33:46 GMT
There are a handful of outstanding Win32 patches that need to be integrated,
Proxy GC being one of them. I plan to spend some time on this next week
(after ApacheCon).

Bill

----- Original Message -----
From: <willem.vanpelt@philips.com>
To: <new-httpd@apache.org>
Sent: Monday, March 06, 2000 5:53 AM
Subject: Re: [PATCH] Proxy Garbage Collection Bug/Win32 PR#4139


> Proxy Garbage Collection Bug/Win32 PR#4139

> Updated this patch to 1.3.13 - patch comes from
> Michael Friedel <mfriedel@lbell.slctnet.com>

I am not to keen on the way this patch has been coded. It generates
quite a bit of unnecessary code.

By reshuffling a couple of lines, it is possible to make the code
generic to *all* operating systems (except for two or three #ifdeffed
lines for OS/2). The way it is now, there is a Unix chunk, an OS/2 chunk,
a TPF chunk and a Win32 chunk. Totally incomprehensible, and worse, hard
to maintain.

Last week, I posted an update of a patch originally made by Klaus Mueller
and Ben Kummer to this list (including a fix for a minor potential bug
they introduced) and additionally I was able to delete about 30 lines of
redundant code instead of generating 30 extra lines :-)


Willem van Pelt,
Senior Software Engineer

Philips Digital Networks - Digital Transmission Systems
Building OAN, room 1.22   Tel: +31-40-27 32564
PO Box 80002              Fax: +31-40-27 36661
5600 JB  Eindhoven, NL
=


Mime
View raw message