httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_auth.c mod_status.c mod_cern_meta.c
Date Sun, 06 Feb 2000 11:12:47 GMT
On 5 Feb 2000 rse@hyperreal.org wrote:
> rse         00/02/05 04:33:17
> 
>   Modified:    src      CHANGES
>                src/modules/standard mod_auth.c mod_status.c mod_cern_meta.c
>   Log:
>   Make implementation/descriptions of the FLAG directives
>   AuthAuthoritative, MetaFiles and ExtendedStatus consistent with
>   documentation and the standard way of implementation those directives.
>...
>   --- mod_status.c	2000/02/02 20:44:06	1.111
>   +++ mod_status.c	2000/02/05 12:33:16	1.112
>   @@ -135,24 +135,19 @@
>     *command-related code. This is here to prevent use of ExtendedStatus
>     * without status_module included.
>     */
>   -static const char *set_extended_status(cmd_parms *cmd, void *dummy, char *arg) 
>   +static const char *set_extended_status(cmd_parms *cmd, void *dummy, int arg) 
>    {
>        const char *err = ap_check_cmd_context(cmd, GLOBAL_ONLY);
>        if (err != NULL) {
>            return err;
>        }
>   -    if (!strcasecmp(arg, "off") || !strcmp(arg, "0")) {
>   -	ap_extended_status = 0;
>   -    }
>   -    else {
>   -	ap_extended_status = 1;
>   -    }
>   +    ap_extended_status = arg;
>        return NULL;
>    }
>    
>    static const command_rec status_module_cmds[] =
>    {
>   -    { "ExtendedStatus", set_extended_status, NULL, RSRC_CONF, TAKE1,
>   +    { "ExtendedStatus", set_extended_status, NULL, RSRC_CONF, FLAG,
>          "\"On\" to enable extended status information, \"Off\" to disable" },
>        {NULL}
>    };

You've changed the allowed values here(!)

ExtendedStatus used to be able to take "0". However, you changed the
directive to use a FLAG which is only "on" and "off".  Hmm. Actually, it
used to be able to take anything.

While the new code conforms to the documentation, it could mess up
existing configurations that used "0" or "1" or something.

Just a yellow flag... I'm -0 on the change.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/


Mime
View raw message