httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: [PATCH] Associating unload_module cleanup with the global pool rather than pconf
Date Thu, 03 Feb 2000 16:46:24 GMT

I think this is bad, but I'm not sure.  We read the config twice, and in
between, we are clearing the pconf pool.  If we register the module
cleanup in the global pool, then when we clear the pconf pool, we'll have
a memory leak, right?  I may be missing something, but I don't think I am.
I think we are better off allocating the pre_config stuff from pconf.  The
pre_config step just means we are doing it before we read the config, to
my way of thinking, the pre-config step is still part of the configuration
and should be done in pconf.

Again, this is all without readng through the code, but I am -1 for this
patch until the memory leak is cleared up in my mind.  :-)

Ryan

On Thu, 3 Feb 2000, Bill Stoddard wrote:

> If I hear no objections, I will commit this patch later today.
> 
> Bill
> cvs diff -u mod_so.c
> Index: mod_so.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_so.c,v
> retrieving revision 1.7
> diff -u -r1.7 mod_so.c
> --- mod_so.c 2000/01/21 19:24:46 1.7
> +++ mod_so.c 2000/02/03 15:38:50
> @@ -276,7 +276,7 @@
>       * we do a restart (or shutdown) this cleanup will cause the
>       * shared object to be unloaded.
>       */
> -    ap_register_cleanup(cmd->pool, modi, 
> +    ap_register_cleanup(g_pHookPool, modi,
>         (ap_status_t (*)(void*))unload_module, ap_null_cleanup);
>  
>      /* 
> 
> 
> ________________________________________________
> Bill Stoddard stoddard@raleigh.ibm.com
> 
> Come to the first official Apache Software Foundation
> Conference!  <http://ApacheCon.Com/>
> 
> 
> 
> 


Come to the first official Apache Software Foundation
Conference!!!   <http://ApacheCon.Com/>

_______________________________________________________________________________
Ryan Bloom                        	rbb@ntrnet.net
2121 Stonehenge Dr. Apt #3
Raleigh, NC 27615		Ryan Bloom -- thinker, adventurer, artist,
				     writer, but mostly, friend.
-------------------------------------------------------------------------------



Mime
View raw message