httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tony Finch <...@dotat.at>
Subject Re: [PATCH] Consistent escaping in LogFormat
Date Mon, 07 Feb 2000 03:15:39 GMT
"Ralf S. Engelschall" <rse@engelschall.com> wrote:
>
>The following patch allows one to consistently escape characters in
>LogFormat strings by prefixing them with the escape backslash ("\x").
>This especially allows one now to also insert percent characters via
>"\%" (see PR#5696).

I'm -0 on the patch as submitted because it makes log format string
parsing less consistent with parsing by other directives and doesn't
allow you to do anything you can't already do via the %% specifier.
Usually ap_getword_conf only \-escapes the quote character; currently
mod_log_config adds to this special handling for only '\n', '\t' and
'\\'; other backslashes pass through unchanged. After the patch it
would swallow backslashes.

Tony.
-- 
               **                              **               
***   ***   ***  **** ***   *******   ***   ***  **** ***   ****
   ***   ***         *   ***       ***   ***         *   ***    

Mime
View raw message