httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manoj Kasichainula <man...@io.com>
Subject Re: ap_set_sub_req_protocol assumes "GET" method
Date Wed, 23 Feb 2000 02:14:27 GMT
BTW, please use unified diffs when possible; they're much easier to
read (and quote).

Instead of doing this, how about we follow the suggestion in
ap_sub_req_method_uri():

    /* would be nicer to pass "method" to ap_set_sub_req_protocol */

In fact, ap_sub_req_method_uri() already seems to do what you're
trying to do to ap_sub_req_lookup_file(), so it would be better to
centralize that change in one place.

On Mon, Feb 21, 2000 at 09:58:54PM -0500, Eric Prud'hommeaux wrote:
> *** src/main/http_protocol-old.c	Thu Apr 29 15:27:46 1999
> --- src/main/http_protocol.c	Thu Apr 29 15:19:49 1999
> ***************
> *** 1120,1127 ****
>       rnew->assbackwards    = 1;   /* Don't send headers from this. */
>       rnew->no_local_copy   = 1;   /* Don't try to send USE_LOCAL_COPY for a
>                                     * fragment. */
> !     rnew->method          = "GET";
> !     rnew->method_number   = M_GET;
>       rnew->protocol        = "INCLUDED";
>   
>       rnew->status          = HTTP_OK;
> --- 1120,1127 ----
>       rnew->assbackwards    = 1;   /* Don't send headers from this. */
>       rnew->no_local_copy   = 1;   /* Don't try to send USE_LOCAL_COPY for a
>                                     * fragment. */
> !     rnew->method          = ap_pstrdup(rnew->pool, r->method);
> !     rnew->method_number   = r->method_number;
>       rnew->protocol        = "INCLUDED";
>   
>       rnew->status          = HTTP_OK;

Mime
View raw message