httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Reid" <ab...@dial.pipex.com>
Subject Re: mod_mmap_static translation hook is never called
Date Fri, 04 Feb 2000 22:17:17 GMT
Bill,

When I hacked mod_mmap_static over to apache 2.0 I brought up this issue and
didn't find an answer either.  The code that I ended up with was the best
that could be done at the time without a lot of messing with hooks etc which
we don't really want to do.

Sorry it took a while to respond but I've been away for a couple of
days...Moscow is very cold and snowy!
:-)
david
----- Original Message -----
From: "Bill Stoddard" <stoddard@raleigh.ibm.com>
To: <new-httpd@apache.org>
Sent: Friday, February 04, 2000 6:11 PM
Subject: Re: mod_mmap_static translation hook is never called


>
> ----- Original Message -----
> From: Bill Stoddard <stoddard@raleigh.ibm.com>
> To: <new-httpd@apache.org>
> Sent: Friday, February 04, 2000 11:11 AM
> Subject: Re: mod_mmap_static translation hook is never called
>
>
> >
> > > "Bill Stoddard" <stoddard@raleigh.ibm.com> wrote:
> > > >
> > > >There is a bug here but I'm not sure of the proper way to fix it.
> > > >[...] mod_mmap depend on mod_core being run before it is run to set
> > > >the r->filename field. In Apache 1.3, mod_mmap_static calls
> > > >core_translate directly (and we can do the same here, but it's such
> > > >an ugly hack...). How should this work with the new hooks?
> > >
> > > What mod_mmap_static wants is an extra hook between filename
> > > translation and the directory walking because only at that point it is
> > > able to say "I know about that file!" and short-circuit all the
> > > stat()s. A more general information cacheing system would hook in
> > > there too; I don't know whether this is enough argument for adding
> > > another hook.
> Just an FYI... I copied the core_translate code into mod_mmap just for
grins
> (and maybe this is a 'fix'). Eliminating the extra ap_stat() improved
> performance 15% (on Windows) when fetching a 500 byte file. I'd expect
less
> of a difference on Linux.
>
> Bill
>


Mime
View raw message