From: Jim Jagielski <jim@jaguNET.com>
Message-Id: <200001042343.SAA01752@devsys.jaguNET.com>
Subject: Re: [PATCH] vhost hostname in scoreboard not useful when using
To: new-httpd@apache.org
Date: Tue, 4 Jan 2000 18:43:58 -0500 (EST)
In-Reply-To: <s8723086.034@WISDOM.UC.WLU.EDU> from "Cliff Woolley" at Jan 04,
 2000 05:39:42 PM
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org
Status: O

Cliff Woolley wrote:
> 
> >>> Jim Jagielski <jim@jaguNET.com> 01/04/00 04:57PM >>>
> >it's because (usually) they have a lot of vhosts or want a
> >simpler conf file or want on-the-fly activation, with the
> >end goal being a leaner faster server. And string copies don't
> >help that :)
> 
> Fair enough.  But you're already doing string copies for the client
> information in the same block of code... so you're not gaining much at
> all as far as "faster" goes.

Well, if you're using ExtendedStatus, then you're not gaining much
anyway as far as speed, since all that does is load up the scoreboard
with human info, not Apache info :)

> 
> I think a few bytes of ap_cpystrn per request is a very small price to
> pay for useful status displays, personally.  Assume you were an ISP that
> had a thousand mass virtual hosts... would you want to have mod_status
> report the same vhost name for every request, regardless of which
> logical host it actually got served by?  I think not.  It makes
> mod_status pretty much useless.
> 

"Assume" ???

In any case, I'm not 100% percent happy with the way it's implemented
as well, but it's the best case for the vast majority of people out
there. This patch is, mainly, for those interested enough in speed
and lean to have mod_vhost_alias installed yet not so concerned that
they are running with full mod_status stats :)

You may note that when I originally did this it did include the static
strings and it was that way for awhile... It's only "recently" been
changed.
-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
                "Are you suggesting coconuts migrate??"