httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: cvs commit: apache-2.0/src/lib/apr/time/unix timestr.c
Date Sun, 23 Jan 2000 02:52:21 GMT

>                src/lib/apr/include apr_portable.h
>                src/lib/apr/locks/unix crossproc.c locks.h
>                src/lib/apr/time/unix timestr.c
>   Log:
>   Make interprocess mutexes actually choose, fix semaphore mutexes.

What does this mean?

>   Index: apr_portable.h
>   ===================================================================
>   RCS file: /export/home/cvs/apache-2.0/src/lib/apr/include/apr_portable.h,v
>   retrieving revision 1.18
>   retrieving revision 1.19
>   diff -u -r1.18 -r1.19
>   --- apr_portable.h	2000/01/09 20:58:22	1.18
>   +++ apr_portable.h	2000/01/23 01:13:45	1.19
>   @@ -81,6 +81,9 @@
>    #if APR_HAVE_PTHREAD_H
>    #include <pthread.h>
>    #endif
>   +#ifdef HAVE_STRUCT_UNION_SEMUN
>   +#include <sys/sem.h>
>   +#endif

This is bad.  We cannot use HAVE_ macros in public header files, because
they aren't namepsace protected.  It really doesn't matter if we named
them ourselves or if autoconf named them for us.  Please change this to
APR_HAVE_STRUCT_UNION_SEMUN.

Ryan


Mime
View raw message