httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/network_io/unix networkio.hsockaddr.c
Date Fri, 21 Jan 2000 16:21:46 GMT
On Fri, 21 Jan 2000, Jim Jagielski wrote:
> Greg Stein wrote:
> > 
> > If I understand correctly, this means we have three versions here:
> > 
> > 1) HAVE_NETINET_IN_H, defined by Apache; for use by all Apache code
> > 2) HAVE_NETINET_IN_H, defined by APR; for use "internally" by APR
> > 3) APR_HAVE_NETINET_IN_H, defined by APR; for private use by the APR
> >    public header files
> > 
> > Can't we combine (2) and (3) by eliminating all uses of (2)? In other
> > words, the APR code uses #if APR_HAVE_NETINET_IN_H throughout.
> > 
> 
> We could also generate a simple filter that takes the APR_FOO header
> macros and does thusly:
> 
>     #define APR_FOO 1     ->    #define FOO
>     #define APR_FOO 0     ->    #undef FOO

Per a followup email from Ryan, macros (2) and (3) have different
semantics. Therefore, we cannot combine them, and we require all three
macros.

(3) could probably go with a new naming scheme, however. (I suggested
something like APR_USE_NETINET_IN_H)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/


Mime
View raw message