httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: [Patch]: Fix mod_mime to hook in the right order. Second attempt.
Date Thu, 20 Jan 2000 19:11:12 GMT

> For no fantastically good reason, I feel that mod_mime_magic should ask
> to run before mod_mime, rather than the other way around, as you have it
> here.

I really disagree.  Mod_mime_magic's docs say it should be used after
mod_mime. 

"This should be listed before mod_mime in the build Configuration file so
that it will be used after mod_mime.  mod_mime_magic is intended as a
"second line of defense" for cases mod_mime cannot resolve.

Plus, mod_mime_magic is horribly innefficient, so if we can avoid using it
because mod_mime can detect the type, then we should.

Ryan


> > Index: mod_mime.c
> > ===================================================================
> > RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_mime.c,v
> > retrieving revision 1.9
> > diff -u -r1.9 mod_mime.c
> > --- mod_mime.c  2000/01/19 02:42:09     1.9
> > +++ mod_mime.c  2000/01/20 15:54:39
> > @@ -386,7 +386,10 @@
> > 
> >  static void register_hooks(void)
> >  {
> > -    ap_hook_type_checker(find_ct,NULL,NULL,HOOK_MIDDLE);
> > +    static const char * const aszPost[]={ "mod_mime_magic.c", NULL };
> > +
> > +    /* mod_mime_magic should be run after mod_mime, if at all. */
> > +    ap_hook_type_checker(find_ct,NULL,aszPost,HOOK_MIDDLE);
> >      ap_hook_post_config(mime_post_config,NULL,NULL,HOOK_MIDDLE);
> >  }
> 
> --
> SECURE HOSTING AT THE BUNKER! http://www.thebunker.net/hosting.htm
> 
> http://www.apache-ssl.org/ben.html
> 
> "My grandfather once told me that there are two kinds of people: those
> who work and those who take the credit. He told me to try to be in the
> first group; there was less competition there."
>      - Indira Gandhi
> 


Come to the first official Apache Software Foundation
Conference!!!   <http://ApacheCon.Com/>

_______________________________________________________________________________
Ryan Bloom                        	rbb@ntrnet.net
2121 Stonehenge Dr. Apt #3
Raleigh, NC 27615		Ryan Bloom -- thinker, adventurer, artist,
				     writer, but mostly, friend.
-------------------------------------------------------------------------------


Mime
View raw message