httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: Annoying unusual bug.
Date Tue, 11 Jan 2000 18:32:16 GMT
On Tue, 11 Jan 2000, Ryan Bloom wrote:
>...
> This is a VERY unusual set of circumstances, but I think it should be
> fixed.  The obvious solution to me, was to allow modules to register
> protocols and default ports.  When we create a redirection url, if the
> default port for the current protocol is used, we leave off the port
> number.  The problem, we don't record the protocol in the request_rec.
> 
> So, my solution:
> add a char *protocol to the request_rec, and have it default to http.
> When the request comes in, if it is anything else, we overwrite this
> default.  This also keeps the SSL modules from having to provide this
> field in the record (I have been told most of them provide it, but I
> haven't checked yet).  This would allow us to register the protocols, and
> the rest of the algorithm works properly.
> 
> Any other thoughts?  If not, I will implement this for Apache 2.0 very
> soon.

I would say to use your approach for 2.0. In the 1.3 series, I'd recommend
*against* altering request_rec and just hard-code recognition of the 443
port.

In other words: minimal change to 1.3 to fix the problem since we're
"doing it right" in the 2.0 series.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/


Mime
View raw message