httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: [Patch]: Fix mod_mime to hook in the right order. Second attempt.
Date Sat, 22 Jan 2000 15:33:54 GMT
"Paul J. Reder" wrote:
> 
> Ben,
> 
> Ben Laurie wrote:
> > Umm. This is an entirely different point ... I was simply saying that I
> > felt that mod_mime_magic should ask to run before mod_mime, instead of
> > mod_mime asking to run after mod_mime_magic.
> 
> Unless I really blew something I was trying to require that mod_mime_magic
> run after mod_mime (not before). Whether that gets done by specifying that
> mod_mime_magic run after mod_mime (in mod_mime), or that mod_mime run before
> mod_mime_magic (in mod_mime_magic) I don't care.
> 
> >
> > I do get your point, but I don't understand how you propose to solve it.
> > If we run ALL, then we get mod_mime_magic's overhead in all cases.
> 
> Yes and no. If mod_mime sets a value for the content_type then
> mod_mime_magic returns right away, no wasted work. But then what is
> the value unless mod_mime_magic could override the value if it chose.
> I don't think that ALL is the answer, just a possibility.

Isn't that the behaviour you get with FIRST?

> > I suspect what we really want is for mod_mime to hook twice, once at
> > MIDDLE, once at LAST. The MIDDLE hook returns known types, or DECLINEs,
> > and the LAST hook returns default types. If mod_mime identifies it,
> > we're done. If not, we try mod_mime_magic (which wants to run _after_
> > mode_mime in this scenario), and if it identifies, we're done, if not,
> > we get the default type, from mod_mime's other hook. We still want the
> > hook to run FIRST.
> 
> This isn't the way the code is written now. If I am understanding the code
> correctly the mod_mime code either identifies a type or it doesn't. There
> is no such thing as "Identifiable" vs. "default". Right now, if mod_mime
> thinks it has the answer, mod_mime_magic never gets a shot. I believe that
> is how 1.3 works also.

Oh? I guess the default type is implemented elsewhere, then? Oh, it is
... in the core but "magically", rather than as I've suggested.

Cheers,

Ben.

--
SECURE HOSTING AT THE BUNKER! http://www.thebunker.net/hosting.htm

http://www.apache-ssl.org/ben.html

"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
     - Indira Gandhi

Mime
View raw message